Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on loading DICOM specs 2022b #16

Merged
merged 2 commits into from
Jul 7, 2022

Conversation

mrbean-bremen
Copy link
Member

- fixes pydicom#15
- also handle 'required only if' prefix
- Python 3.6 has been EOL for 6 months now
@codecov-commenter
Copy link

Codecov Report

Merging #16 (c0a8e6b) into main (33948a4) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   83.85%   84.24%   +0.39%     
==========================================
  Files          14       14              
  Lines        1344     1365      +21     
==========================================
+ Hits         1127     1150      +23     
+ Misses        217      215       -2     
Impacted Files Coverage Δ
dicom_validator/spec_reader/condition.py 100.00% <100.00%> (ø)
dicom_validator/spec_reader/condition_parser.py 98.34% <100.00%> (+0.82%) ⬆️
dicom_validator/spec_reader/part3_reader.py 91.62% <0.00%> (+0.04%) ⬆️
dicom_validator/validator/iod_validator.py 92.52% <0.00%> (+0.10%) ⬆️
dicom_validator/spec_reader/spec_reader.py 90.90% <0.00%> (+0.34%) ⬆️
dicom_validator/spec_reader/edition_reader.py 75.71% <0.00%> (+1.21%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@mrbean-bremen mrbean-bremen merged commit cb7da41 into pydicom:main Jul 7, 2022
@mrbean-bremen mrbean-bremen deleted the complex-cond branch August 12, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IndexError parsing 2022b
2 participants