Fix zarr upstream tests #9927
Merged
Fix zarr upstream tests #9927
+40
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
commented
Jan 6, 2025
dcherian
force-pushed
the
fix-zarr-upstream
branch
from
8d08ac0 to
6e0d521
Compare
Co-authored-by: Matthew Iannucci <[email protected]>
dcherian
force-pushed
the
fix-zarr-upstream
branch
from
6e0d521 to
4a85fcd
Compare
dcherian
commented
Jan 6, 2025
Comment on lines
+2698
to
+2700
| encoding_key = "compressors" if has_zarr_v3 else "compressor" | ||
| comp = Blosc(cname="zstd", clevel=3, shuffle=2) | ||
| encoding = {encoding_key: (comp,) if has_zarr_v3 else comp} |
There was a problem hiding this comment.
This all feels a bit silly. "compressors" instead of "compressor" and now a tuple instead of a single object.
There was a problem hiding this comment.
we had to pluralize it to make things work with zarr v3. fwiw I proposed "compression" as an arity-ambiguous version, but that wasn't popular enough
dcherian
added
run-upstream
dcherian
force-pushed
the
fix-zarr-upstream
branch
from
33d5992 to
4b5def7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I was over-eager in clicking the release button on Friday :(
whats-new.rstapi.rstcc @d-v-b