feat: optional colab specific adc #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, the unit tests failing with python 2.7 and python 3.6 also failed in local |
ashleyxuu
pushed a commit
to googleapis/python-bigquery-dataframes
that referenced
this pull request
Sep 26, 2023
The original PR: https://team-review.git.corp.google.com/c/bigquery-query-swe/bigframes/+/1873071 And the corresponding change in pydata-google-auth: pydata/pydata-google-auth#68 Change-Id: Ic41f7064687699c4f328aa8dfe2cadcb51f29c6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libraries using pydata-google-auth (such as google-cloud-bigquery, ibis) are often used in google colab notebook which has its own user authentication mechanism to ensure application default credentials. We want to use the same if needed under the hood.
Related issue: #64