Scival submodule #377
Draft
Scival submodule #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the new Scival submodule with 1 function Publication lookup
Have added tests to test the properties
Uses the utils and superclasses
Given the list of Scival API's here - https://dev.elsevier.com/api_docs.html
I would appreciate some feedback on the naming of classes so I can improve the PR.
I plan to build all of the functions available, Proposing this PR for early feedback.
Happy to amend this PR based on feedback.
Your help on this request is much appreciated.
Linked to #203 #253