Remove dev vcpkg install #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Saransh-cpp
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Nice!
I haven't looked at this repository before, but I notice that the files have been copied from PyBaMM, but the git history is not there. This is exactly the situation where one would want the git history to be present (could do a git blame and see who added this potentially harmful dev installation if vcpkg (me haha! because it was a necessity at that time + not really harmful)).
I am not sure if that can be done now, but we should definitely investigate.
MarcBerliner
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes an outdated installation of the dev version of vcpkg
Related to pybamm-team/PyBaMM#4632