Skip to content

Commit

Permalink
Drop ROS 2 Iron support (Ekumen-OS#454)
Browse files Browse the repository at this point in the history
### Proposed changes

ROS 2 Iron Irwini reached EOL as of late November 2024 and was
officially phased out a bit over a week ago
https://discourse.ros.org/t/iron-irwini-is-end-of-life/41031. As a
consequence, plain `rosdep resolve` started failing in CI, see Ekumen-OS#452.

We have no reason to continue supporting ROS 2 Iron, thus this patch
drops support for it entirely.

#### Type of change

- [x] 🐛 Bugfix (change which fixes an issue)
- [ ] 🚀 Feature (change which adds functionality)
- [ ] 📚 Documentation (change which fixes or extends documentation)

### Checklist

- [x] Lint and unit tests (if any) pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have added necessary documentation (if appropriate)
- [x] All commits have been signed for
[DCO](https://developercertificate.org/)

---------

Signed-off-by: Michel Hidalgo <[email protected]>
  • Loading branch information
hidmic authored Dec 20, 2024
1 parent ce8405a commit b2748e4
Show file tree
Hide file tree
Showing 9 changed files with 3 additions and 128 deletions.
1 change: 0 additions & 1 deletion .github/workflows/ci_pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ jobs:
ros_distro:
- noetic
- humble
- iron
- jazzy
include:
- ros_distro: humble
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/docker_ci_pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
ros_distro:
- noetic
- humble
- iron
- jazzy
- rolling
steps:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/weekly_pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ jobs:
ros_distro:
- noetic
- humble
- iron
- jazzy
- rolling
container:
Expand Down
2 changes: 1 addition & 1 deletion DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ To bring up a development environment:
(cd beluga && ROSDISTRO=humble docker/run.sh)
```

Supported distributions include `noetic`, `humble`, `iron`, `jazzy`, and `rolling`.
Supported distributions include `noetic`, `humble`, `jazzy`, and `rolling`.

## Workflow

Expand Down
4 changes: 2 additions & 2 deletions beluga_tools/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
<license>Apache License 2.0</license>


<!-- The released debian for h5py package when on humble or iron seems to have a bug where it's incompatible with numpy's 2.0.0 version.
<!-- The released debian for h5py package when on humble seems to have a bug where it's incompatible with numpy's 2.0.0 version.
We will install newest package version using pip in the development images to circumvent this..
See:
https://github.com/h5py/h5py/issues/2353
-->
<exec_depend condition="$ROS_VERSION == 2 and $ROS_DISTRO != 'humble' and $ROS_DISTRO != 'iron'">python3-h5py</exec_depend>
<exec_depend condition="$ROS_VERSION == 2 and $ROS_DISTRO != 'humble'">python3-h5py</exec_depend>
<exec_depend condition="$ROS_VERSION == 2">python3-matplotlib</exec_depend>
<exec_depend condition="$ROS_VERSION == 2">python3-numpy</exec_depend>
<exec_depend condition="$ROS_VERSION == 2">python3-scipy</exec_depend>
Expand Down
5 changes: 0 additions & 5 deletions docker/files/iron.repos

This file was deleted.

113 changes: 0 additions & 113 deletions docker/images/iron/Dockerfile

This file was deleted.

Binary file removed docs/_images/iron_irwini_logo.jpg
Binary file not shown.
4 changes: 0 additions & 4 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,10 +143,6 @@ Beluga is supported on a number of ROS 1 and ROS 2 distributions, primarily on L
:text-align: center
![ROS 2 Humble Hawksbill logo](./_images/humble_hawksbill_logo.png)
:::
:::{grid-item-card} ROS 2 Iron Irwini
:text-align: center
![ROS 2 Iron Irwini logo](./_images/iron_irwini_logo.jpg)
:::
:::{grid-item-card} ROS 2 Jazzy Jalisco
:text-align: center
![ROS 2 Jazzy Jalisco logo](./_images/jazzy_jalisco_logo.png)
Expand Down

0 comments on commit b2748e4

Please sign in to comment.