Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature 1131 Introduce Modelattribue isBacklogQuarter #1334

Merged
merged 39 commits into from
Jan 30, 2025
Merged

Feature 1131 Introduce Modelattribue isBacklogQuarter #1334

merged 39 commits into from
Jan 30, 2025

Conversation

Miguel7373
Copy link
Collaborator

No description provided.

@Miguel7373 Miguel7373 linked an issue Jan 23, 2025 that may be closed by this pull request
Introduce Modelattribue isBacklog #1131
Closed
5 tasks
@ManuelMoeri ManuelMoeri force-pushed the feature/1131-introduce-modelattribute-isBacklog branch from 9198911 to d459545 Compare January 27, 2025 08:35
@ManuelMoeri ManuelMoeri marked this pull request as ready for review January 30, 2025 07:11
MasterEvarior
MasterEvarior requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@MasterEvarior MasterEvarior left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Just some very minor things regarding the test, then we are ready to merge 🥇

backend/src/test/java/ch/puzzle/okr/controller/QuarterControllerIT.java Outdated Show resolved Hide resolved
backend/src/test/java/ch/puzzle/okr/service/business/OverviewBusinessServiceTest.java Outdated Show resolved Hide resolved
Miguel7373 and others added 23 commits January 30, 2025 10:01
@Miguel7373 @ManuelMoeri
add dto and mapper for quater to send isBacklogQarter to frontend
da3731b
@Miguel7373 @ManuelMoeri
fix unit and e2e tests
321f0c7
@Miguel7373 @ManuelMoeri
remove regex in error interceptor
7942535
@Miguel7373 @ManuelMoeri
add isBacklogQuarter to quarter min and implement it in the objective…
21905fe 
… menu
@Miguel7373 @ManuelMoeri
formatt backend and remove useless regex
62892cd
@Miguel7373 @ManuelMoeri
remove methode and the unit tests for it
5e89dad
@Miguel7373 @ManuelMoeri
fix isBacklogQuarter usage in error interceptor
d718c3c
@Miguel7373 @ManuelMoeri
fix e2e test
bd6bccc
@Miguel7373 @ManuelMoeri
add isBacklogQuarter to objective mapper to check for it in the error…
f5831fa 
… interceptor
@Miguel7373 @ManuelMoeri
formatting and remove useless lines
b6589b7
@Miguel7373 @ManuelMoeri
fix objective dto bilder and test data
c54aa0e
@Miguel7373 @ManuelMoeri
add missing attributes to objective creations
2574f87
@Miguel7373 @ManuelMoeri
fix e2e test
d89f21b
@ManuelMoeri
Annotate mapper with component to fix backend tests
d8e3c65
@ManuelMoeri
Format backend
e4b61b5
@ManuelMoeri
Resolve first two conversations
9d1864b
@ManuelMoeri
Rename selector to better match
4445463
@ManuelMoeri
Remove unwanted attribute on ObjectiveDto and mapper
9723e65
@ManuelMoeri
Revert changes
422b791
@ManuelMoeri
Fix mistake
3553b21
@RandomTannenbaum @ManuelMoeri
Remove quarter label and isbacklogquarter from objective dto
8a46d32
@RandomTannenbaum @ManuelMoeri
Fix backend tests
6411d34
@RandomTannenbaum @ManuelMoeri
Run backend formatter
653088b
RandomTannenbaum and others added 13 commits January 30, 2025 10:01
@RandomTannenbaum @ManuelMoeri
Remove error interceptor backlog logic in frontend and fix frontend t…
50ced1f 
…ests
@RandomTannenbaum @ManuelMoeri
Add transient field isBacklogQuarter to overview and set it in busine…
42cb2f7 
…ss service
@RandomTannenbaum @ManuelMoeri
Format backend
5403974
@RandomTannenbaum @ManuelMoeri
Correctly case name of constant
37a1556
@RandomTannenbaum @ManuelMoeri
Fix backend tests
5870679
@ManuelMoeri
Format backend
30a8956
@ManuelMoeri
Add first solution for error interceptor not returning correct error …
23b6219 
…message
@ManuelMoeri
Remove not existing attribute in test and write test for isBacklogQua…
075015d 
…rter attribute
@ManuelMoeri
Add model test for isBacklogQuarter method and format code
9739160
@ManuelMoeri
Fix error interceptor test after accidentally deleting the wrong attr…
a9d3bb6 
…ibute
@ManuelMoeri
Readd tests of objective menu actions and modify them to match the cu…
155faa3 
…rrent logic
@ManuelMoeri
Change type of mock to be more specific than any and remove recundanc…
27e8070 
…e in test file
@ManuelMoeri
Format backend
cab42b1
@ManuelMoeri ManuelMoeri force-pushed the feature/1131-introduce-modelattribute-isBacklog branch from 2572f45 to cab42b1 Compare January 30, 2025 09:01
@MasterEvarior MasterEvarior merged commit cdce6b0 into main Jan 30, 2025
18 checks passed
@MasterEvarior MasterEvarior deleted the feature/1131-introduce-modelattribute-isBacklog branch January 30, 2025 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterEvarior MasterEvarior MasterEvarior approved these changes

@kcinay055679 kcinay055679 kcinay055679 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Introduce Modelattribue isBacklog
5 participants
@Miguel7373 @MasterEvarior @kcinay055679 @ManuelMoeri @RandomTannenbaum