Fix intermittendly failing file browser test #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change 47c72c2 tried to address the intermittendly failing test, but I think made the mistake of "hardcoding" the file we assume to be removing from the attachment list. The problem however is, that the list of files we're adding as attachment varies with the environment. While the `screenshot.png` is probably the attachment in most cases, it isn't the attachment in **all** cases. The assertion that the next screen does not show a file which we never added is always true. Instead, firstly, this patch asserts that the last filename is actually listed as an attachment. Secondly, we assert that when the attachment is removed the last file from before is gone. Furthermore we also check whether the item count has changed. Fixes: #327
This uses what we've learned in the previous change and applies it to the remaining tests using a "Not" condition without asserting the presence of the element in the first place. This only applies to asserting that something was present in the previous screen and is now gone in the subsequent screen.
|
Wow, will this really fix it forever? merge when green, I don't have the headspace to work this all out rn but I trust you mate! |
|
Cheers! Yeah it annoyed me quite a bit for my last pull request. I hope I got now all bases covered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change 47c72c2 tried to address the
intermittendly failing test, but I think made the mistake of
"hardcoding" the file we assume to be removing from the attachment list.
The problem however is, that the list of files we're adding as
attachment varies with the environment. While the
screenshot.pngisprobably the attachment in most cases, it isn't the attachment
in all cases. The assertion that the next screen does not show a
file which we never added is always true.
Instead, firstly, this patch asserts that the last filename is actually
listed as an attachment. Secondly, we assert that when the attachment is
removed the last file from before is gone. Furthermore we also check
whether the item count has changed.
Fixes: #327