Refactor and Logic Testing

lib/facter/pe_status_check.rb

@@ -249,43 +249,42 @@
     if File.exist?(suite_license_file)
       # Presence of file satisfy check
       validity = true
-      # Approve with only suite-license.liu
-      { S0022: validity }
-    elsif File.exist?(license_file)
-      begin
-        license_type = File.readlines(license_file).grep(%r{license_type:}).first
-        if license_type.nil?
-          validity = true
-        elsif license_type.include? 'Perpetual'
-          validity = true
-        elsif license_type.include? 'Subscription'
-          require 'date'
-          begin
-            end_date = Date.parse(File.readlines(license_file).grep(%r{end:}).first)
-            today_date = Date.today
-            daysexp = (end_date - today_date).to_i
-            validity = ((today_date <= end_date) && (daysexp >= 90)) ? true : false
-          rescue StandardError => e
-            Facter.warn("Error in fact 'pe_status_check.S0022' when checking license end date: #{e.message}")
-            Facter.debug(e.backtrace)
-            # license file has missing or invalid end date
+    else
+      elsif File.exist?(license_file)
+        begin
+          license_type = File.readlines(license_file).grep(%r{license_type:}).first
+          if license_type.nil?
+            validity = true
+         elsif license_type.include? 'Perpetual'
+            validity = true
+          elsif license_type.include? 'Subscription'
+            require 'date'
+            begin
+              end_date = Date.parse(File.readlines(license_file).grep(%r{end:}).first)
+              today_date = Date.today
+              daysexp = (end_date - today_date).to_i
+              validity = ((today_date <= end_date) && (daysexp >= 90)) ? true : false
+            rescue StandardError => e
+              Facter.warn("Error in fact 'pe_status_check.S0022' when checking license end date: #{e.message}")
+              Facter.debug(e.backtrace)
+              # license file has missing or invalid end date
+              validity = false
+            end
+          else
+            # license file has invalid license_type
             validity = false
           end
-        else
-          # license file has invalid license_type
+        rescue StandardError => e
+          Facter.warn("Error in fact 'pe_status_check.S0022' when checking license type: #{e.message}")
           validity = false
         end
-      rescue StandardError => e
-        Facter.warn("Error in fact 'pe_status_check.S0022' when checking license type: #{e.message}")
+      else
+        # Neither suite-license.lic nor license.key exist
         validity = false
       end
-    else
-      # Neither suite-license.lic nor license.key exist
-      validity = false
-    end
 
-    { S0022: validity }
-  end
+      { S0022: validity }
+    end
 
   chunk(:S0023) do
     # Is the CA_CRL expiring in the next 90 days