Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup .fixtures.yml #2506

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Cleanup .fixtures.yml #2506

merged 4 commits into from
Jan 3, 2024

Conversation

bastelfreak
Copy link
Collaborator

Summary

Provide a detailed description of all the changes present in this pull request.

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't speak for the puppet_agent unpinning, but the rest looks good to me.

@smortex
Copy link
Collaborator

smortex commented Jan 2, 2024

@bastelfreak the cla check prevent this from being merged. Can you check if maybe this was committed with the wrong author info? This seems safe to merge IMHO.

@smortex
Copy link
Collaborator

smortex commented Jan 3, 2024

Close and reopen to trigger a new cla check

@smortex smortex closed this Jan 3, 2024
@smortex smortex reopened this Jan 3, 2024
@smortex smortex merged commit a521d39 into puppetlabs:main Jan 3, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants