pdksync - 'CAT-945 - Update README.md LICENSE' #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramesh7
requested review from
bastelfreak,
ekohl,
smortex and
a team
as code owners
rajat-puppet
previously approved these changes
Nov 20, 2023
smortex
reviewed
Nov 20, 2023
README.md
Outdated
| @@ -860,6 +861,10 @@ COVERAGE=yes bundle exec rake parallel_spec | |||
| Acceptance tests for this module leverage [puppet_litmus](https://github.com/puppetlabs/puppet_litmus). | |||
| To run the acceptance tests follow the instructions [here](https://puppetlabs.github.io/litmus/Running-acceptance-tests.html). You can also find a tutorial and walkthrough of using Litmus and the PDK on [YouTube](https://www.youtube.com/watch?v=FYfR7ZEGHoE). | |||
|
|
|||
| ## License | |||
|
|
|||
| This codebase is licensed under the Apache2.0 licensing, however due to the nature of the codebase the open source dependencies may also use a combination of [AGPL](https://www.gnu.org/licenses/agpl-3.0.en.html), [BSD-2](https://opensource.org/license/bsd-2-claus), [BSD-3](https://opensource.org/license/bsd-3-claus), [GPL2.0](https://www.gnu.org/licenses/old-licenses/gpl-2.0.en.html), [LGPL](https://opensource.org/license/lgpl-3-0/), [MIT](https://opensource.org/license/mit/) and [MPL](https://opensource.org/license/mpl-2-0/) Licensing. | |||
There was a problem hiding this comment.
2 things:
- Does it make sense to use a single website to access "details" of each license? AGPL-v3 is available on opensource.com: https://opensource.org/license/agpl-v3/, same for GPL-2.0: https://opensource.org/license/gpl-2-0/
- The BSD license URL seems to have been trimmed. But they seems to redirect to the correct locations: https://opensource.org/license/bsd-2-clause/ / https://opensource.org/license/bsd-3-clause/. Maybe better use the final location?
I saw a bunch of other PRs, this apply to these too.
malikparvez
approved these changes
Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'CAT-945 - Update README.md LICENSE'
pdk version:
3.0.0