Skip to content

Commit

Permalink
Merge pull request #383 from puppetlabs/CAT-1688-Upgrade_rubocop
Browse files Browse the repository at this point in the history
(CAT-1688) Upgrade rubocop to `~> 1.50.0`
  • Loading branch information
jordanbreen28 authored Jan 23, 2024
2 parents 2206408 + 7aa3290 commit 474f761
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 11 deletions.
3 changes: 3 additions & 0 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ AllCops:
Style/ClassAndModuleChildren:
Enabled: false

Layout/LineLength:
Max: 200

####################################################
# Cops below here due for deprecation
####################################################
Expand Down
12 changes: 2 additions & 10 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2023-09-25 08:38:34 UTC using RuboCop version 1.56.3.
# on 2024-01-22 15:21:03 UTC using RuboCop version 1.50.2.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -123,7 +123,7 @@ RSpec/DescribeClass:
- 'spec/acceptance/generate_markdown_spec.rb'
- 'spec/acceptance/running_strings_generate_spec.rb'

# Offense count: 51
# Offense count: 48
# Configuration parameters: CountAsOne.
RSpec/ExampleLength:
Max: 66
Expand Down Expand Up @@ -159,7 +159,6 @@ Style/ClassVars:
- 'lib/puppet-strings/yard/templates/default/layout/html/setup.rb'

# Offense count: 3
# This cop supports unsafe autocorrection (--autocorrect-all).
Style/CombinableLoops:
Exclude:
- 'lib/puppet-strings/markdown.rb'
Expand Down Expand Up @@ -188,10 +187,3 @@ Style/OptionalBooleanParameter:
- 'lib/puppet-strings/yard/code_objects/type.rb'
- 'lib/puppet-strings/yard/handlers/ruby/data_type_handler.rb'
- 'lib/puppet-strings/yard/handlers/ruby/function_handler.rb'

# Offense count: 136
# This cop supports safe autocorrection (--autocorrect).
# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, AllowedPatterns.
# URISchemes: http, https
Layout/LineLength:
Max: 199
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ group :development do
gem 'rspec', '~> 3.1'
gem 'rspec-its', '~> 1.0'

gem 'rubocop', '~> 1.48', require: false
gem 'rubocop', '~> 1.50.0', require: false
gem 'rubocop-performance', '~> 1.16', require: false
gem 'rubocop-rspec', '~> 2.19', require: false

Expand Down

0 comments on commit 474f761

Please sign in to comment.