(maint) Update clojure/test.check to match other projects #99
Conversation
project.clj
Outdated
| @@ -8,7 +8,7 @@ | |||
| :pedantic? :abort | |||
| :dependencies [[org.clojure/clojure] | |||
| [org.clojure/java.jdbc] | |||
| [org.clojure/test.check "0.9.0"] | |||
| [org.clojure/test.check "1.1.1"] | |||
There was a problem hiding this comment.
Shouldn't this be in the test dependencies so it's not transitively picked up by other projects?
Then this whole situation goes away.
There was a problem hiding this comment.
Probably, come to think of it. A thing that may not have been known when it was added 8 years ago 🤔 Happy to move it there if we think that's fine.
There was a problem hiding this comment.
It does only seem to be used in tests (wanted to make sure it wasn't used in helpers for other libraries' tests). I'll move it.
Magisus
force-pushed
the
update-clojure-test-check
branch
from
8626d66 to
3ff3706
Compare
|
I added a thing to trigger tests on changes to |
This commit moves the `clojure/test.check` dependency to the `test` lein profile, since it is only used in tests. This will prevent it from being picked up transitively by other projects that depend on `jdbc-util`. Previously, this could sometimes cause ambiguous dependency resolution, since other projects, notably jar-jar and puppetdb, also pull in `clojure/test.check`, recently at a different version than this library. In addition to moving it to a test dependency, this commit also updates the test library to the version used by other projects in the PE ecosystem.
Magisus
force-pushed
the
update-clojure-test-check
branch
2 times, most recently
from
99890b0 to
af3240f
Compare
|
The test failures appears to be related to this https://www.postgresql.org/message-id/tencent_BD6B866E25069560051D16A1EEA07A4F2908%40qq.com and seems legit. I think this is the offending code: jdbc-util/src/puppetlabs/jdbc_util/core.clj Lines 114 to 116 in 092001b It was missed when we upgraded from Postgres 9 to 14 here, because the tests are gated to only run on changes to |
|
I would remove the PRs are few and far between, and tests are quick enough, just run them all for any change. To fix the issue now, we could try pinning to the latest image that does work? |
Magisus
force-pushed
the
update-clojure-test-check
branch
3 times, most recently
from
ff3a487 to
7df6318
Compare
Postgres 14.7 started enforcing a restriction where databases could not be created or dropped as part of a pipeline of SQL commands. We are doing that in our `create-db` function when the user that is designated to be the DB owner is not part of the `db-owner` role or a superuser. That code should be fixed, though the fact that this isn't causing a problem in PE, which is currently using Postgres 14.13, likely means this path is unused. In the meantime, this commit pins CI for this repo to 14.6, where the existing code is still allowed.
Magisus
force-pushed
the
update-clojure-test-check
branch
from
7df6318 to
525ccc2
Compare
|
If it's quick (an hour or two), I say we fix the |
Jar-jar and puppetdb now use version 1.1.1 of
clojure.test/check, so this library's pin to 0.9.0 causes dependency confusion in projects that depend on this and either of those. This commit updates the version used here to match the rest of the PE ecosystem.