Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #2765 from AriaXLi/maint/jruby_ubuntu_inte… #2770

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Revert "Merge pull request #2765 from AriaXLi/maint/jruby_ubuntu_inte… #2770

merged 1 commit into from
Oct 10, 2024

Conversation

AriaXLi
Copy link
Contributor

@AriaXLi AriaXLi commented Oct 10, 2024 •
edited
Loading

…gration_failure"

This reverts commit 92a6484, reversing changes made to bbb2d35.

Previously, sys-filesystem 1.5.2 caused some integration check failures, but after the release of sys-filesystem 1.5.3, these failures went away.

@AriaXLi
Revert "Merge pull request puppetlabs#2765 from AriaXLi/maint/jruby_u…
f4b5e62 
…buntu_integration_failure"

This reverts commit 92a6484, reversing
changes made to bbb2d35.

Previously, sys-filesystem 1.5.2 caused some integration check failures,
but after the release of sys-filesystem 1.5.3, these failures went away.
@AriaXLi AriaXLi requested a review from a team as a code owner October 10, 2024 21:15
@AriaXLi
Copy link
Contributor Author

AriaXLi commented Oct 10, 2024 •
edited
Loading

I opened #2769 to test to see if the failures resolved and they did

@AriaXLi
Copy link
Contributor Author

AriaXLi commented Oct 10, 2024 •
edited
Loading

Also verified the failures went away on an Ubuntu 22.04 VM:

root@ip-10-227-4-200:~# rbenv global jruby-9.3.14.0
root@ip-10-227-4-200:~# bundle update
Using sys-filesystem 1.5.3
root@ip-10-227-4-200:~/facter# bundle exec rake spec_integration
Finished in 3 minutes 50.7 seconds (files took 27.02 seconds to load)
137 examples, 0 failures

@joshcooper joshcooper merged commit 543b962 into puppetlabs:main Oct 10, 2024
18 checks passed
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshcooper joshcooper joshcooper approved these changes

Assignees
No one assigned
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AriaXLi @joshcooper