Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(FACT-3442) Update os.architecture fact for debian to arm64 #2627

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

shubhamshinde360
Copy link
Contributor

No description provided.

@shubhamshinde360 shubhamshinde360 requested a review from a team as a code owner October 20, 2023 10:04
Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. We'll need the same change applied to Ubuntu too, as they follow arm64 convention for packages, for example libc https://packages.ubuntu.com/jammy/libc6

@joshcooper
Copy link
Contributor

I modified the test for Ubuntu and ran beaker tests:

$  bx rake ci:test:setup SHA=2793d324ee8ff297a717ef8a508181b0f0c87a91 HOSTS=ubuntu2204-AARCH64a
$  bx beaker exec tests/facts/os_processors_and_kernel.rb
...
        "os": {
          "architecture": "arm64",
          "distro": {
            "codename": "jammy",
            "description": "Ubuntu 22.04.2 LTS",
            "id": "Ubuntu",
            "release": {
              "full": "22.04",
              "major": "22.04"
            }
          },
          "family": "Debian",
          "hardware": "aarch64",
          "name": "Ubuntu",
          "release": {
            "full": "22.04",
            "major": "22.04"
          },
          "selinux": {
            "enabled": false
          }
        },
...
tests/facts/os_processors_and_kernel.rb passed in 3.83 seconds

@joshcooper joshcooper merged commit d1ce081 into puppetlabs:main Oct 20, 2023
@joshcooper joshcooper added the maintenance Maintenance chores are excluded from changelogs label Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance chores are excluded from changelogs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants