(FACT-3441) improve reliability of uname resolver #2620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathannewman
force-pushed
the
maint/main/dont-deref-nil
branch
from
65a9c17 to
3e50ce2
Compare
|
Note that in testing, we are seeing occasional failures with puppetserver failing to start because of nil dereferences related to this code. |
|
Sorry @jonathannewman I forgot about this. Could you file a JIRA and update the commit summary to reference that? |
jonathannewman
force-pushed
the
maint/main/dont-deref-nil
branch
from
3e50ce2 to
dbf8ff3
Compare
jonathannewman
changed the title
|
@joshcooper done! |
jonathannewman
force-pushed
the
maint/main/dont-deref-nil
branch
from
dbf8ff3 to
61f18e6
Compare
|
@jonathannewman could you rebase to pick up this change #2625? |
In the case that the uname command fails to return expected content, this adds validation to the output looking for both an empty result, or missing results. Logging is added to help identify the condition.
jonathannewman
force-pushed
the
maint/main/dont-deref-nil
branch
from
61f18e6 to
25edad7
Compare
|
Sorry @joshcooper didn't see your ping. rebased. |
mhashizume
approved these changes
Oct 26, 2023
|
Thanks for this @jonathannewman ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the uname command fails to return expected content, this adds validation to the output looking for both an empty result, or missing results.
Logging is added to help identify the condition.