Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tom alphalab blink detection #634

Closed
wants to merge 13 commits into from
Closed

Tom alphalab blink detection #634

wants to merge 13 commits into from

Conversation

N-M-T
Copy link
Collaborator

@N-M-T N-M-T commented Nov 13, 2023

No description provided.

N-M-T
N-M-T commented Nov 13, 2023
View reviewed changes
src/alpha-lab/README.md Outdated Show resolved Hide resolved
N-M-T
N-M-T commented Nov 13, 2023
View reviewed changes
Copy link
Collaborator Author

@N-M-T N-M-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpfffr, I pushed some changes and left some comments. Let me know if you have any questions!

@tpfffr tpfffr requested review from willpatera and removed request for willpatera November 13, 2023 10:37
willpatera
willpatera reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@willpatera willpatera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads really well so far! I have a few minor comments and questions for you to consider @tpfffr

src/alpha-lab/blink_detection.md Outdated Show resolved Hide resolved
src/alpha-lab/blink_detection.md Outdated Show resolved Hide resolved
src/alpha-lab/blink_detection.md Outdated Show resolved Hide resolved
src/alpha-lab/blink_detection.md Outdated Show resolved Hide resolved
src/alpha-lab/blink_detection.md Outdated Show resolved Hide resolved
src/alpha-lab/blink_detection.md Outdated Show resolved Hide resolved
@willpatera
Copy link
Member

@tpfffr changes look good to me 😸

@N-M-T any additional comments?

@N-M-T
Copy link
Collaborator Author

N-M-T commented Nov 27, 2023

@tpfffr changes look good to me 😸

@N-M-T any additional comments?

I don't have additional comments on this, @willpatera

@mikelgg93 mikelgg93 mentioned this pull request Nov 28, 2023
Merged
4 tasks
@mikelgg93
Copy link
Member

Superseded by #643

@mikelgg93 mikelgg93 closed this Nov 28, 2023
@N-M-T N-M-T deleted the tom_alphalab_blink_detection branch December 4, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpfffr tpfffr tpfffr left review comments

@willpatera willpatera willpatera left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@N-M-T @willpatera @mikelgg93 @tpfffr