-
Notifications
You must be signed in to change notification settings - Fork 145
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested two changes. Once the issue concerning other file changes are resolved, this is good to go.
themes/default/content/docs/esc/other-integrations/kubernetes.md
Outdated
Show resolved
Hide resolved
themes/default/content/docs/esc/other-integrations/kubernetes.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a couple of more suggestions.
themes/default/content/docs/esc/other-integrations/kubernetes.md
Outdated
Show resolved
Hide resolved
themes/default/content/docs/esc/other-integrations/kubernetes.md
Outdated
Show resolved
Hide resolved
9c52f56
to
7429cba
Compare
This comment was marked as outdated.
This comment was marked as outdated.
bd53431
to
3537fd2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing that the stepper at the bottom of each "integration" is there by accident, because the integrations aren't a tutorial or guide that you step through, and it didn't seem to be working properly.
Your site preview for commit 3537fd2 is ready! 🎉 http://pulumi-hugo-origin-pr-4260-3537fd2a.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @EronWright !
Site previews for this pull request have been removed. ✨ |
Description
Adds an ESC documentation page for Kubernetes integration.
Closes: pulumi/pulumi-kubernetes#2965
Checklist: