Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

K8 - Pulumi ESC Docs #4260

Merged
merged 2 commits into from
May 10, 2024
Merged

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented May 10, 2024

Description

Adds an ESC documentation page for Kubernetes integration.

Closes: pulumi/pulumi-kubernetes#2965

Checklist:

  • I have reviewed the style guide.
  • If blogging, I have reviewed the blogging guide.
  • I have manually confirmed that all new links work.
  • I added aliases (i.e., redirects) for all filename changes.
  • If making css changes, I rebuilt the bundle.

@pulumi-bot

This comment was marked as outdated.

@arunkumar611 arunkumar611 self-requested a review May 10, 2024 00:39
Copy link
Member

@arunkumar611 arunkumar611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested two changes. Once the issue concerning other file changes are resolved, this is good to go.

Copy link
Member

@arunkumar611 arunkumar611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a couple of more suggestions.

@EronWright EronWright force-pushed the eronwright/issue-kubernetes-2965-esc branch from 9c52f56 to 7429cba Compare May 10, 2024 16:35
@pulumi-bot

This comment was marked as outdated.

@EronWright EronWright requested a review from arunkumar611 May 10, 2024 16:38
@EronWright EronWright force-pushed the eronwright/issue-kubernetes-2965-esc branch from bd53431 to 3537fd2 Compare May 10, 2024 16:50
@pulumi-bot

This comment was marked as outdated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing that the stepper at the bottom of each "integration" is there by accident, because the integrations aren't a tutorial or guide that you step through, and it didn't seem to be working properly.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 3537fd2 is ready! 🎉

http://pulumi-hugo-origin-pr-4260-3537fd2a.s3-website.us-west-2.amazonaws.com.

Copy link
Member

@arunkumar611 arunkumar611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @EronWright !

@EronWright EronWright merged commit 9508a6f into master May 10, 2024
2 checks passed
@EronWright EronWright deleted the eronwright/issue-kubernetes-2965-esc branch May 10, 2024 17:07
Copy link

Site previews for this pull request have been removed. ✨

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

K8 - Pulumi ESC Docs
3 participants