Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Provider OIDC Guides #3554

Merged
merged 15 commits into from
Nov 3, 2023
Merged

Provider OIDC Guides #3554

merged 15 commits into from
Nov 3, 2023

Conversation

toriancrane
Copy link
Contributor

@toriancrane toriancrane commented Oct 30, 2023 •
edited
Loading

Description

This PR moves, consolidates, and updates OIDC content to accommodate for multiple services.

URL paths for updated content:

  • /docs/pulumi-cloud/oidc/
  • /docs/pulumi-cloud/oidc/aws/
  • /docs/pulumi-cloud/oidc/azure/
  • /docs/pulumi-cloud/oidc/gcp/
  • /docs/pulumi-cloud/esc/providers/

References

Will resolve the following issues:

To-Do

  • Update GCP OIDC page
  • Add links to automation examples
  • Move OIDC content to live under Pulumi Cloud rather than Deployments
  • Generalize OIDC hub page content and separate service specific content
  • Update AWS OIDC page
    • Add gifs
  • Update Azure OIDC page
  • Update ESC providers page to remove duplicate content and link to OIDC hub page

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 99fcb60 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-99fcb601.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane mentioned this pull request Oct 30, 2023
Closed
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 2c8825f is ready! 🎉

http://pulumi-hugo-origin-pr-3554-2c8825fc.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 87459bd is ready! 🎉

http://pulumi-hugo-origin-pr-3554-87459bd3.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane changed the title Azure OIDC "esc run' guide Provider OIDC Guides Nov 1, 2023
@toriancrane toriancrane mentioned this pull request Nov 1, 2023
Closed
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 9421531 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-9421531b.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 1ef01c1 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-1ef01c1a.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit cb7d857 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-cb7d8579.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 83424c8 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-83424c83.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit af15093 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-af150939.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 7fd2ff5 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-7fd2ff5c.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane marked this pull request as ready for review November 2, 2023 09:03
@toriancrane toriancrane requested a review from a team November 2, 2023 09:04
scottslowe
scottslowe approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good work! My only suggestion (and I don't feel it necessary to block on this, so I'm approving the PR) is to consider adding a link to the main Pulumi Cloud page (found at /docs/pulumi-cloud). Otherwise, the only way to know there's an OIDC section is to look in the sidebar (my sidebar is collapsed by default, so I might have entirely missed the OIDC content).

@toriancrane
Copy link
Contributor Author

This is good work! My only suggestion (and I don't feel it necessary to block on this, so I'm approving the PR) is to consider adding a link to the main Pulumi Cloud page (found at /docs/pulumi-cloud). Otherwise, the only way to know there's an OIDC section is to look in the sidebar (my sidebar is collapsed by default, so I might have entirely missed the OIDC content).

Great idea! I will add this and merge.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit 6ab0308 is ready! 🎉

http://pulumi-hugo-origin-pr-3554-6ab0308f.s3-website.us-west-2.amazonaws.com.

@toriancrane toriancrane merged commit e8d9d57 into master Nov 3, 2023
1 check passed
@toriancrane toriancrane deleted the torian/esc-run-azure branch November 3, 2023 08:37
@toriancrane toriancrane mentioned this pull request May 10, 2024
Closed
@cnunciato cnunciato mentioned this pull request Nov 3, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@scottslowe scottslowe scottslowe approved these changes

@interurban interurban Awaiting requested review from interurban interurban is a code owner

@cnunciato cnunciato Awaiting requested review from cnunciato

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toriancrane @pulumi-bot @scottslowe