This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
Remove Registry module and await in-progress workflows #3547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnunciato
force-pushed
the
cnunciato/await-in-prog
branch
from
c28918e to
1134b87
Compare
|
Your site preview for commit 1134b87 is ready! 🎉 http://pulumi-hugo-origin-pr-3547-1134b87f.s3-website.us-west-2.amazonaws.com. |
sean1588
approved these changes
Oct 26, 2023
cnunciato
force-pushed
the
cnunciato/await-in-prog
branch
from
1134b87 to
7c9ce32
Compare
|
Your site preview for commit 7c9ce32 is ready! 🎉 http://pulumi-hugo-origin-pr-3547-7c9ce32e.s3-website.us-west-2.amazonaws.com. |
cnunciato
force-pushed
the
cnunciato/await-in-prog
branch
from
7c9ce32 to
4e16109
Compare
|
Your site preview for commit 4e16109 is ready! 🎉 http://pulumi-hugo-origin-pr-3547-4e16109c.s3-website.us-west-2.amazonaws.com. |
|
Site previews for this pull request have been removed. ✨ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to https://github.com/pulumi/pulumi-hugo-private/issues/112, this change does a couple of things, both aimed at reducing the likelihood of the merge conflicts we see when running the
pushandupstream-syncworkflows:hugo mod getthat attempts to pull in the latest from pulumi/registry (along with the reference to that module in the Hugo config). There's no technical need to import this module, particularly since the Registry now runs as a completely separate app; the only purpose it serves is to show something at /registry in PR previews and in local development. (Removing this therefore means navigating to /registry in PR previews and in local development will 404, but I'm assuming that won't cause too much pain for contributors to this repo.)pushworkflows to finish before running the current one. This will ensure thatpushworkflows always complete in the order in which they're merged (so that multiple merges that happen in proximity won't run into the same class of problem by producing CSS and JS bundles out of sequence). This is the same script we use in pulumi/docs for this purpose.