Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Fix C# snippet #3450

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix C# snippet #3450

merged 2 commits into from
Oct 25, 2023

Conversation

iamdmitrij
Copy link
Contributor

Description

Noticed that official C# documentation has a code which doesn't compile: https://www.pulumi.com/docs/languages-sdks/dotnet/#example
Snippet was simply missing a class modifier.

  • Fix C# documentation snippet

@interurban interurban added area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec labels Oct 24, 2023
@toriancrane toriancrane self-assigned this Oct 25, 2023
Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

After testing the proposed update, I have just one requested change. The deployment still fails with the updated code because the resource group definition is missing the required "location" argument.

public class MyStack : Stack
{
    public MyStack()
    {
        // Create an Azure Resource Group
        var resourceGroup = new ResourceGroup("resourceGroup", new()
        {
            Location = "West Europe",
        });
        ...
        ...
        // the rest of the code example

If you can include this with your update, I can approve it and get it merged. Thanks again!

@toriancrane toriancrane added this to the 0.96 milestone Oct 25, 2023
@iamdmitrij
Copy link
Contributor Author

Thank you for your contribution!

After testing the proposed update, I have just one requested change. The deployment still fails with the updated code because the resource group definition is missing the required "location" argument.

public class MyStack : Stack
{
    public MyStack()
    {
        // Create an Azure Resource Group
        var resourceGroup = new ResourceGroup("resourceGroup", new()
        {
            Location = "West Europe",
        });
        ...
        ...
        // the rest of the code example

If you can include this with your update, I can approve it and get it merged. Thanks again!

Good catch, thanks! Fixed it now.

Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@toriancrane toriancrane added resolution/fixed This issue was fixed and removed awaiting-feedback labels Oct 25, 2023
@toriancrane toriancrane merged commit 88188f4 into pulumi:master Oct 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/docs Improvements or additions to documentation kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants