Added support for throwing errors from CDK stack metadata #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
PR is now waiting for a maintainer to run the acceptance tests. This PR will only perform build and linting. |
|
@karakter98 with the latest changes, this should now work. Let me know if you experience any other issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow tools like cdk-nag to cause runtime errors when running the Pulumi program by attaching errors and warnings as metadata to the CDK cloud assembly.
Before, using cdk-nag in a Pulumi program would not print the error messages to the console, and the
pulumi upcommand could go through even if cdk-nag checks were failing.This PR added dependencies, because it uses the CDK CLI package to parse the stack metadata and emit the errors/warnings. The
aws-cdk-libpackage lacks this functionality.Closes #86