Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add docs and example for multi region stacks #303

Merged
merged 2 commits into from
Jan 2, 2025

Conversation

corymhall
Copy link
Contributor

@corymhall corymhall commented Dec 20, 2024

This adds some docs on multi stack setup. The only scenario where you maybe should use multiple stacks is when you are deploying to multiple regions since stack is the most granular level you can configure the environment.

As part of this PR i've also added an example test that uses CloudFront and Lambda@Edge since that is a common scenario where users would need to deploy resources to multiple regions. The test is skipped because Lambda@Edge resources cannot be easily cleaned up (they are removed from all AWS regions in the background).

@corymhall corymhall marked this pull request as draft December 20, 2024 17:16
resources cannot be cleaned-up in CI.

Updating README with TOC and multi-stack section
@corymhall corymhall force-pushed the corymhall/multi-region-example branch from c715e35 to 69ba148 Compare December 24, 2024 16:48
@corymhall corymhall changed the title chore: update cloudfront example to show multi region chore: add docs and example for multi region stacks Dec 24, 2024
@corymhall corymhall marked this pull request as ready for review December 24, 2024 16:56
@corymhall corymhall self-assigned this Dec 24, 2024
Copy link
Contributor

@flostadler flostadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only worried about the ToC going out of sync

@@ -91,6 +91,28 @@ Try the workshop at https://apprunnerworkshop.com
Read the docs at https://docs.aws.amazon.com/apprunner
```

## Table of Contents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub shows a ToC by default. I'm worried that the manually created one goes out of sync eventually
Screenshot 2025-01-02 at 18 44 36

@corymhall corymhall merged commit 90b4655 into main Jan 2, 2025
13 checks passed
@corymhall corymhall deleted the corymhall/multi-region-example branch January 2, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants