Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add workflow to upgrade @pulumi/aws-native workflow #255

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

corymhall
Copy link
Contributor

This PR adds a workflow that automates updating the @pulumi/aws-native dependency. This one is a special case because the metadata.json file also needs to be updated.

fixes #149

(cd $(dirname $e) && yarn install)
(cd $(dirname $e) && yarn upgrade "@pulumi/aws-native@^${VERSION}")
dir=$(dirname $e)
npx ncu --filter @pulumi/aws-native --upgrade --cwd $dir
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to ncu since it handles upgrading to the latest minor version.

@blampe
Copy link
Contributor

blampe commented Nov 26, 2024

Renovate could (probably?) handle this for you, e.g. #251

Let me know if you'd like to change anything about the current behavior. For example you can break aws-native out into its own group if you don't want to bundle it with other Pulumi deps.

Auto-approve/auto-merge doesn't currently work because it's still waiting for reviews. I'm planning on deploying a bot to stamp PRs if tests pass.

@corymhall
Copy link
Contributor Author

@blampe

Renovate could (probably?) handle this for you

Can renovate run custom commands as part of the upgrade? We need to also update the metadata.json file.

@t0yv0
Copy link
Member

t0yv0 commented Nov 26, 2024

The only non-standard AWS native dependency is borrowing the metadata json file (which we could alternatively express as a submodule). Happy to move this to renovate but probably also wouldn't block on it and just land this and fix later.

This PR adds a workflow that automates updating the @pulumi/aws-native
dependency. This one is a special case because the metadata.json file
also needs to be updated.

fixes #149
@corymhall corymhall force-pushed the corymhall/upgrade-workflow branch from d9223a1 to 34b5e8f Compare November 26, 2024 17:37
@corymhall corymhall enabled auto-merge (squash) November 26, 2024 17:59
@blampe
Copy link
Contributor

blampe commented Nov 26, 2024

@blampe

Renovate could (probably?) handle this for you

Can renovate run custom commands as part of the upgrade? We need to also update the metadata.json file.

Right now it allows a make build command to run after it resolves dependencies, but you would need to declare that in a renovate.json5 local to this repo. We can tweak the name of the command. Running something before it resolves is currently unsupported, but in-progress AFAIK.

@corymhall corymhall merged commit 5b9817d into main Nov 26, 2024
13 checks passed
@corymhall corymhall deleted the corymhall/upgrade-workflow branch November 26, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup dependency updates
3 participants