Improve the Ref intrinsic implementation #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t0yv0
changed the title
|
Acceptance tests catching something, excellent, I'll have a look. |
corymhall
approved these changes
Nov 25, 2024
| return ctx.getRegion(); | ||
| case 'AWS::URLSuffix': | ||
| return ctx.getURLSuffix(); | ||
| case 'AWS::NotificationARNs': |
There was a problem hiding this comment.
I think this was actually a bug I introduced when I enabled use of StackId & StackName. AWS::NotificationARNs should still throw an error because it is not supported.
|
|
||
| return ctx.apply(ctx.succeed(propValues), (resolvedValues) => { | ||
| let i = 0; | ||
| for (const v of resolvedValues) { |
There was a problem hiding this comment.
Nit:
resolvedValues.forEach((v, idx) => {
...
})There was a problem hiding this comment.
forEach wouldn't have the early return. To express this functionally this would be a reduce, but perhaps having written too much Go since my FP days I prefer the imperative version now for readability.
flostadler
approved these changes
Nov 25, 2024
Co-authored-by: Cory Hall <[email protected]>
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds some tests and comments around the
Refintrinsic implementation and moves it tointrinsics.ts. The one change in behavior is that nowRefis able to consult Pulumi metadata from theaws-nativeprovider. The metadata helps it resolve to the same values as it would in CloudFormation for resources that have non-standardRefbehavior. The correctness of this process is up to the correctness of the metadata tables. Entries not found in the metadata tables default to using Pulumiidfor most cases should do the right thing.Fixes #173
Needs pulumi/pulumi-aws-native#1836