Enable autoTrim behavior by default
#227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enables the aws-native `AutoNaming.autoTrim` feature by default. It does this by creating an aws-native provider by default if the user does not provide one. I've updated tests to remove the workarounds. **Alternatives** 1. We could require that the user configure this themselves. 2. Is there a way to set config values programatically? closes #62, closes #70
corymhall
force-pushed
the
corymhall/auto-trim
branch
from
e208e8e to
42113c6
Compare
t0yv0
reviewed
Nov 19, 2024
src/stack.ts
Outdated
| const region = native.config.region ?? process.env.AWS_REGION ?? process.env.AWS_DEFAULT_REGION!; | ||
| // If the user has not provided any providers, we will create an aws-native one by default in order | ||
| // to enable the autoNaming feature. | ||
| const providers = props?.providers ?? [ |
There was a problem hiding this comment.
This could be a bit more precise maybe? If props resets the classic provider, it might still be able to merge in the config for the native provider? Probably a rare use case though, feel free to disregard.
There was a problem hiding this comment.
Yeah that's a good call. I've updated it to handle that case.
t0yv0
approved these changes
Nov 19, 2024
flostadler
approved these changes
Nov 19, 2024
|
This PR has been shipped in release v1.0.0. |
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the aws-native
AutoNaming.autoTrimfeature by default.It does this by creating an aws-native provider by default if the user
does not provide one.
I've updated tests to remove the workarounds.
Alternatives
closes #62, closes #70