chore(examples): update api-websocket-lambda-dynamodb example #146
Conversation
This PR makes a couple of updates to the api-websocket-lambda-dynamodb
example test
- Updates the Lambda runtime to `NODEJS_LATEST`
- This also requires switching from `aws-sdk` (v2) to
`@aws-sdk/client-*` (v3)
- Updates the CDK code to use L2s instead of L1s
- Adds validation to the test to ensure that the code actually works (it
didn't)
closes #144, re #145
There was a problem hiding this comment.
The individual package.json files are not needed since the Lambda functions are not bundling any dependencies.
There was a problem hiding this comment.
I kept getting flaky test failures with this one so I just decided to update it as part of this PR.
The example that this had of creating a LB/Target group via pulumi and then the rest of the resources as CDK L1s doesn't really make sense. At that point it just makes more sense to create the entire thing as pulumi resources since they are the same level of abstraction.
This still shows an example of taking pulumi outputs (the vpc info) and using that as inputs to CDK constructs.
| @@ -90,8 +101,6 @@ func TestS3ObjectLambda(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestEC2Instance(t *testing.T) { | |||
| t.Skipf("skipping due to missing support for `AWS::EC2::SecurityGroup`") | |||
| // It shouldn't be necessary to retry this, but my testing was very inconsistent, sometimes the `Dial` | ||
| // triggered the connect and sometimes it didn't (according to the docs it shouldn't be possible to establish | ||
| // a connection without triggering $connect) | ||
| func isConnected(ctx context.Context, t *testing.T, table string, c *websocket.Conn, client *dynamodb.Client, canRetry bool) error { |
There was a problem hiding this comment.
I thought this was going to be easy, but it ended up being extremely annoying/difficult 😖
It might not even be worth it at this point...
| @@ -444,7 +444,6 @@ export function mapToAwsResource( | |||
| const policy = new aws.iam.Policy( | |||
| logicalId, | |||
| { | |||
| name: rawProps.PolicyName, | |||
There was a problem hiding this comment.
CloudFormation requires that a name be set so CDK sets a name automatically, but if not set then pulumi will auto name it which is better.
This fixes some inter-test conflicts.
examples/appsvc/index.ts
Outdated
| filters: [ | ||
| { | ||
| name: 'opt-in-status', | ||
| values: ['opt-in-not-required'], |
examples/appsvc/index.ts
Outdated
| // }); | ||
| const azs = pulumi.output( | ||
| aws | ||
| .getAvailabilityZones({ |
There was a problem hiding this comment.
nit: you could do aws.getAvailabilityZonesOutput().names.
| @@ -47,7 +45,7 @@ export class Ec2CdkStack extends pulumicdk.Stack { | |||
|
|
|||
| // Use Latest Amazon Linux Image - CPU Type ARM64 | |||
| const ami = new ec2.AmazonLinuxImage({ | |||
| generation: ec2.AmazonLinuxGeneration.AMAZON_LINUX_2, | |||
| generation: ec2.AmazonLinuxGeneration.AMAZON_LINUX_2023, | |||
This PR makes a couple of updates to the api-websocket-lambda-dynamodb
example test
NODEJS_LATESTaws-sdk(v2) to@aws-sdk/client-*(v3)didn't)
closes #144, re #145