Create aws ccapi resources by using the SDK #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates our mapping to create resources using the SDK directly instead of creating a `pulumi.CustomResource`. By using a `pulumi.CustomResource` we were missing out on all the resource specific things from the generated SDK. (`replaceOnChanges`, required property validation, etc). closes #216
corymhall
commented
Nov 13, 2024
| @@ -114,6 +114,7 @@ describe('App Converter', () => { | |||
| examplebucketPolicyE09B485E: { | |||
| Type: 'AWS::S3::BucketPolicy', | |||
| Properties: { | |||
| PolicyDocument: {}, | |||
There was a problem hiding this comment.
These updates to the tests are required because it now validates required properties.
flostadler
approved these changes
Nov 14, 2024
| const mName = moduleName(typeName).toLowerCase(); | ||
| const pType = pulumiTypeName(typeName); | ||
| const awsModule = aws as any; | ||
| return new awsModule[mName][pType](logicalId, props, options); |
There was a problem hiding this comment.
Neat!
This only works for resources that are nested in a module. Which is fine as there's only the ExtensionResource on the root level, which we do not use, and all CFN resources are nested in a module!
|
This PR has been shipped in release v1.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our mapping to create resources using the SDK directly
instead of creating a
pulumi.CustomResource. By using apulumi.CustomResourcewe were missing out on all the resource specificthings from the generated SDK. (
replaceOnChanges, required propertyvalidation, etc).
closes #216