Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS CCAPI resources should be invoked from the SDK #216

Closed
corymhall opened this issue Nov 13, 2024 · 2 comments · Fixed by #217
Closed

AWS CCAPI resources should be invoked from the SDK #216

corymhall opened this issue Nov 13, 2024 · 2 comments · Fixed by #217
Assignees
@corymhall
Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed

Comments

@corymhall
Copy link
Contributor

What happened?

When we create aws-native resources via the mapping, we use a pulumi.CustomResource instead of the appropriate class from the aws-native sdk.

pulumi-cdk/src/interop.ts

Line 87 in 5912f83

export class CfnResource extends pulumi.CustomResource {

This means that we don't get any of the generated sdk stuff like replaceOnChanges.

Example

Deploy the examples/fargate example and then change the taskDefinition image. The TaskDefinition should be replaced because containerDefinitions is replaceOnChange.

Output of pulumi about

n/a

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).
@corymhall corymhall added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Nov 13, 2024
@corymhall corymhall self-assigned this Nov 13, 2024
@corymhall corymhall removed the needs-triage Needs attention from the triage team label Nov 13, 2024
@cleverguy25
Copy link

Added to epic https://github.com/pulumi/home/issues/2191

corymhall added a commit that referenced this issue Nov 13, 2024
@corymhall
Create aws ccapi resources by using the SDK
2a8c074 
This PR updates our mapping to create resources using the SDK directly
instead of creating a `pulumi.CustomResource`. By using a
`pulumi.CustomResource` we were missing out on all the resource specific
things from the generated SDK. (`replaceOnChanges`, required property
validation, etc).

closes #216
@corymhall corymhall mentioned this issue Nov 13, 2024
Merged
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Nov 14, 2024
@pulumi-bot
Copy link
Contributor

This issue has been addressed in PR #217 and shipped in release v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corymhall corymhall

Labels
kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Create aws ccapi resources by using the SDK pulumi/pulumi-cdk
3 participants
@cleverguy25 @pulumi-bot @corymhall