Skip to content

Commit

Permalink
chore: cdk deps need to be the same for examples (#176)
Browse files Browse the repository at this point in the history
CDK libraries have a weird requirement that only a single version of
`aws-cdk-lib` and `constructs` be installed. This means that the
`devDependency` in `package.json` and the dependencies in each
`examples` `package.json` needs to be the same. If they are different
versions then the examples will fail with `Argument of type 'this' is
not assignable to parameter of type 'Construct'.`

Note: the `peerDependency` is still a floating version so users can
still install the range of versions.

fixes #175
  • Loading branch information
corymhall authored Oct 23, 2024
1 parent 5bb37e9 commit 9f3122e
Show file tree
Hide file tree
Showing 11 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion examples/alb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0"
}
}
2 changes: 1 addition & 1 deletion examples/api-websocket-lambda-dynamodb/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"@pulumi/cdk": "^0.5.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111"
"constructs": "10.3.0"
}
}
2 changes: 1 addition & 1 deletion examples/apprunner/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0",
"@aws-cdk/aws-apprunner-alpha": "2.20.0-alpha.0"
}
Expand Down
2 changes: 1 addition & 1 deletion examples/appsvc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0"
}
}
2 changes: 1 addition & 1 deletion examples/cron-lambda/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0"
}
}
2 changes: 1 addition & 1 deletion examples/ec2-instance/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0"
}
}
2 changes: 1 addition & 1 deletion examples/ecscluster/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0"
}
}
2 changes: 1 addition & 1 deletion examples/fargate/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"@pulumi/cdk": "^0.5.0"
}
}
2 changes: 1 addition & 1 deletion examples/s3-object-lambda/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@
"@pulumi/aws-native": "^0.117.0",
"@pulumi/pulumi": "^3.0.0",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111"
"constructs": "10.3.0"
}
}
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"@types/mock-fs": "^4.13.4",
"@types/node": "^20.12.13",
"aws-cdk-lib": "2.149.0",
"constructs": "^10.0.111",
"constructs": "10.3.0",
"eslint": "^8.57.0",
"eslint-config-prettier": "^9.1.0",
"jest": "^29.5.0",
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2157,7 +2157,7 @@ [email protected]:
resolved "https://registry.yarnpkg.com/concat-map/-/concat-map-0.0.1.tgz#d8a96bd77fd68df7793a73036a3ba0d5405d477b"
integrity sha512-/Srv4dswyQNBfohGpz9o6Yb3Gz3SrUDqBH5rTuhGR7ahtlbYKnVxw2bCFMRljaA7EXHaXZ8wsHdodFvbkhKmqg==

constructs@^10.0.111:
constructs@10.3.0:
version "10.3.0"
resolved "https://registry.yarnpkg.com/constructs/-/constructs-10.3.0.tgz#4c246fce9cf8e77711ad45944e9fbd41f1501965"
integrity sha512-vbK8i3rIb/xwZxSpTjz3SagHn1qq9BChLEfy5Hf6fB3/2eFbrwt2n9kHwQcS0CPTRBesreeAcsJfMq2229FnbQ==
Expand Down

0 comments on commit 9f3122e

Please sign in to comment.