Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TestAutonaming flakiness #1984

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

flostadler
Copy link
Contributor

TestAutonaming occasionally fails if test runs are running within 1 minute of each other because SQS does not allow recreating a deleted queue within 60s:

          aws-native:sqs:Queue (queue):
            error: creating resource: creating resource (await): operation CREATE failed with "Throttling": You must wait 60 seconds after deleting a queue before you can create another with the same name. (Service: Sqs, Status Code: 400, Request ID: 7503e9ea-2fa2-5fba-b1cc-b6117f9af4d4)

To fix this I added some random parts to the resource name

Fixes #1983

@flostadler flostadler requested review from t0yv0, mikhailshilkov, corymhall and a team January 13, 2025 14:00
@flostadler flostadler self-assigned this Jan 13, 2025
Copy link
Contributor

Does the PR have any schema changes?

Looking good! No breaking changes found.
No new resources/functions.

Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.04%. Comparing base (be58c79) to head (14b38b9).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1984   +/-   ##
=======================================
  Coverage   51.04%   51.04%           
=======================================
  Files          49       49           
  Lines        7052     7052           
=======================================
  Hits         3600     3600           
  Misses       3200     3200           
  Partials      252      252           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flostadler flostadler merged commit 4104243 into master Jan 13, 2025
18 checks passed
@flostadler flostadler deleted the flostadler/autonaming-test-fix branch January 13, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test TestAutonaming
3 participants