chore: do not clean untracked files #1887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know why we were running `git clean` here, but we don't do that in any other providers. This is preventing our check worktree clean job to correctly catch when new sdk files are not checked in. fixes #1827
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1887 +/- ##
=======================================
Coverage 49.29% 49.29%
=======================================
Files 46 46
Lines 6804 6804
=======================================
Hits 3354 3354
Misses 3206 3206
Partials 244 244 ☔ View full report in Codecov by Sentry. |
flostadler
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why we were running
git cleanhere, but we don't do thatin any other providers. This is preventing our check worktree clean job
to correctly catch when new sdk files are not checked in.
fixes #1827