-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend metadata with descriptors of CF Ref handling #1836
Merged
Merged
Changes from 56 commits
Commits
Show all changes
57 commits
Select commit
Hold shift + click to select a range
ff27a56
WIP on categorizing Ref docu
t0yv0 7f53cbd
Colocate property names
t0yv0 9443d13
Adding a guessing game
t0yv0 5f2766c
Guessing a few more resources
t0yv0 cc199e1
Add a Makefile target
t0yv0 469a10c
More information
t0yv0 caaa962
Fix typo
t0yv0 e32087a
Sort prop options by primary key index
t0yv0 4d6b326
Label some more resources
t0yv0 39fd303
Print stats; more labels
t0yv0 d38dd01
Allow marking Not Supported
t0yv0 d9de7d2
More labels
t0yv0 d8640c8
More labels
t0yv0 2c83641
N=62 labels
t0yv0 b0fa8fa
N=81 labels
t0yv0 d25399e
N=91 labels
t0yv0 8a7d4ae
Note JSON-encoded Properties
t0yv0 a09a34c
N=121 labels
t0yv0 9f5d997
Improve RefReturnsArn recognizer
t0yv0 8018e8a
Implement automatic heuristic labelling
t0yv0 9d7fdff
Add a target for automatic heuristic labelling
t0yv0 48f53db
Auto label some resources
t0yv0 ac58717
Recognize RefReturnsName categories
t0yv0 98039a3
Name based heuristic
t0yv0 fe3c226
Apply more heuristics
t0yv0 add63d4
Improve the Name heuristic
t0yv0 a64434a
Apply the name heuristic
t0yv0 bf70e2b
Further improve the name heuristic
t0yv0 c99525d
Apply the improved Name heuristic; N=266
t0yv0 04fea9c
Improve Arn category recognizer
t0yv0 574b095
Apply heuristics
t0yv0 eadeb3f
More ARN recognizers
t0yv0 a75e510
Add an ID heuristic
t0yv0 91f1501
Better ARN heuristic
t0yv0 9d181fd
Improved name heuristic
t0yv0 550486a
Better ARN heuristic
t0yv0 c0f9cff
Better ARN heuristic
t0yv0 0794355
Correct a bug
t0yv0 fc38dfd
Better ID heuristic
t0yv0 cdc53c4
Better ID heuristic
t0yv0 30ca419
Improved ID heuristic
t0yv0 f6bdc04
Better ARN heuristic
t0yv0 e466077
More key resources
t0yv0 e31e437
Toward including top-100 used resources
t0yv0 fb7e897
Add a README folder for the data
t0yv0 aae3db6
Add a header
t0yv0 26a19d6
Move CfRefBehavior into the medatada
t0yv0 09660cb
Share refdb code
t0yv0 c77ffb4
Weave CF Ref metadata into the provider metadata
t0yv0 f91f587
Fix failing test
t0yv0 e908ce1
Basic data quality reporting
t0yv0 3e6d1e4
Manually cover AWS::EC2::SecurityGroup
t0yv0 67433c3
Run CF to confirm AWS::IAM::RolePolicy behavior and schematize it
t0yv0 29053da
Confirmed experimentally that Secret.Id is also the ARN
t0yv0 10fe2d1
More data cleaning
t0yv0 ff9c0ab
Regenerate metadata
t0yv0 eb0829b
PR feedback
t0yv0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
# meta | ||
|
||
Reference data used by the `pulumi-aws-native` provider. | ||
|
||
## ref-db.json | ||
|
||
Metadata describing the behavior of the [CloudFormation Ref Intrinsic](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-ref.html). | ||
|
||
What Ref returns varies from resource to resource. The only available information on this is free-form text in CloudFormation documentation and anything that can be extracted experimentally. To facilitate building tooling such as `pulumi/pulumi-cdk` that emulates CF behavior, `ref-db.json` collects schematized information describing the behavior of `Ref`. | ||
|
||
`ref-db.json` can be edited directly to correct errors or add entries for resources not yet covered. | ||
|
||
## regions.json | ||
|
||
AWS regions and their names. | ||
|
||
Please do not edit this file directly. | ||
|
||
This list can be refreshed by extracting from `botocore`. See `.botocore.version`. | ||
|
||
make docs |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example here on what it looks like to update this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You send a PR and edit it? I'm not sure I understand. It just has to conform to the schema.