Handle PENDING Operation Status #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1228 +/- ##
==========================================
+ Coverage 12.77% 13.07% +0.29%
==========================================
Files 22 22
Lines 4703 4711 +8
==========================================
+ Hits 601 616 +15
+ Misses 4046 4039 -7
Partials 56 56 ☔ View full report in Codecov by Sentry. |
danielrbradley
approved these changes
Dec 20, 2023
We don't actually run the preview during the test, but it's not a great example if it fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1219
This could have been a one liner, but I decided to pull out a helper method to add a test. There are a couple other values of
OperationStatusthat we may need to handle in the future, but I'm punting on those, b/c I haven't seen them in the wild and I'm not 100% sure how they ought to be handled.