Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redirects for ai answers #13837

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

sean1588
Copy link
Member

@sean1588 sean1588 commented Jan 16, 2025

This code reverts the redirects added to redirect traffic from old ai answers app to the new one. This was tested and verified to be working in the testing environment at pulumi-test.io. These redirects were initially added to redirect traffic from the old ai answers app at pulumi.com/ai/answers to the new app at pulumi.com/answers. We then decided it would be best not to associate the old app with the new and to just 404 the old routes. So this PR reverts the redirects.

@pulumi-bot
Copy link
Collaborator

1 similar comment
@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

@sean1588 sean1588 force-pushed the sean/remove-ai-answer-redirect branch from 2326541 to afecc00 Compare January 16, 2025 18:40
@pulumi-bot
Copy link
Collaborator

@sean1588 sean1588 requested review from thoward and arturl January 17, 2025 17:20
@arturl
Copy link
Member

arturl commented Jan 17, 2025

@sean1588 can you add "before" and "after" screenshots? Or a link to the new page in the preview site? I cannot tell from the code what page is being changed.

@sean1588
Copy link
Member Author

@sean1588 can you add "before" and "after" screenshots? Or a link to the new page in the preview site? I cannot tell from the code what page is being changed.

thanks @arturl , this was deployed and verified in the test environment at pulumi-test.io. The preview doesn't account these types of updates since they are just served out of a standalone s3 bucket.

Example url:
https://www.pulumi.com/ai/answers/gDRe8E82CE6D5CTqpAXB1L/automating-aws-s3-file-expiration - redirects in prod
https://www.pulumi-test.io/ai/answers/gDRe8E82CE6D5CTqpAXB1L/automating-aws-s3-file-expiration - now 404s in test

Copy link
Contributor

@thoward thoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing I'd add is some code comments describing the change in behavior and, if possible link to whatever decision making documentation we have available (e.g. Slack convo link, Google Doc, etc). Ideally, someone unfamiliar with this problem should be able to read this file and understand why we are doing it this way (and that it's intentional).

@sean1588 sean1588 changed the title remove redirects for ai answers Remove redirects for ai answers Jan 22, 2025
@sean1588 sean1588 merged commit 56c038c into master Jan 22, 2025
27 checks passed
@sean1588 sean1588 deleted the sean/remove-ai-answer-redirect branch January 22, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants