-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redirects for ai answers #13837
Conversation
028508a
to
afecc00
Compare
Your site preview for commit afecc00 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-afecc008.s3-website.us-west-2.amazonaws.com. |
1 similar comment
Your site preview for commit afecc00 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-afecc008.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 028508a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-028508a1.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 2c18e97 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-2c18e972.s3-website.us-west-2.amazonaws.com. |
2c18e97
to
afecc00
Compare
Your site preview for commit 5ac07f3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-5ac07f33.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit afecc00 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-afecc008.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit 2326541 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-2326541a.s3-website.us-west-2.amazonaws.com. |
2326541
to
afecc00
Compare
Your site preview for commit afecc00 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13837-afecc008.s3-website.us-west-2.amazonaws.com. |
@sean1588 can you add "before" and "after" screenshots? Or a link to the new page in the preview site? I cannot tell from the code what page is being changed. |
thanks @arturl , this was deployed and verified in the test environment at pulumi-test.io. The preview doesn't account these types of updates since they are just served out of a standalone s3 bucket. Example url: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only thing I'd add is some code comments describing the change in behavior and, if possible link to whatever decision making documentation we have available (e.g. Slack convo link, Google Doc, etc). Ideally, someone unfamiliar with this problem should be able to read this file and understand why we are doing it this way (and that it's intentional).
This code reverts the redirects added to redirect traffic from old ai answers app to the new one. This was tested and verified to be working in the testing environment at pulumi-test.io. These redirects were initially added to redirect traffic from the old ai answers app at pulumi.com/ai/answers to the new app at pulumi.com/answers. We then decided it would be best not to associate the old app with the new and to just 404 the old routes. So this PR reverts the redirects.