Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move rails_app dependency out of sidekiq_worker role #5730

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maxkadel
Copy link
Contributor

  • This reduces duplicate runs of sub-tasks of rails_app
  • This also removes a order-dependent bug where sometimes the nginx restart task would not run when the sidekiq_workers was run on only some boxes
  • This moves toward the possibility of future further specialization of web and worker boxes - e.g., web boxes need passenger and node, worker boxes may or may not need passenger and node.

@maxkadel maxkadel force-pushed the move_sidekiq_worker_dependency branch from 4085838 to f09f35f Compare January 13, 2025 17:59
- This reduces duplicate runs of sub-tasks of rails_app
- This also removes a order-dependent bug where sometimes the nginx restart task would not run when the sidekiq_workers was run on only some boxes
- This moves toward the possibility of future further specialization of web and worker boxes - e.g., web boxes need passenger and node, worker boxes may or may not need passenger and node.
@maxkadel maxkadel force-pushed the move_sidekiq_worker_dependency branch from f09f35f to 1ee681e Compare January 13, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant