Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EZProxy] I4788 ezproxy test #5726

Merged
merged 7 commits into from
Jan 13, 2025
Merged

[EZProxy] I4788 ezproxy test #5726

merged 7 commits into from
Jan 13, 2025

Conversation

VickieKarasic
Copy link
Contributor

No description provided.

kayiwa and others added 6 commits January 10, 2025 13:38
this is a file that is supposed to allow a group of princeton IP address

Co-authored-by: Beck Davis <[email protected]>
Co-authored-by: Vickie Karasic <[email protected]>
Co-authored-by: Kevin Reiss <[email protected]>
this was a missing file in config.txt that controls ip ranges
Co-authored-by: Beck Davis <[email protected]>
Co-authored-by: Vickie Karasic <[email protected]>
Co-authored-by: Kevin Reiss <[email protected]>
Co-authored-by: Beck Davis <[email protected]>
Co-authored-by: Francis Kayiwa <[email protected]>

Co-authored-by: Kevin Reiss <[email protected]>
@VickieKarasic VickieKarasic changed the title I4788 ezproxy test [EZProxy] I4788 ezproxy test Jan 10, 2025
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the EZproxy automation so we can rebuild our EZproxy servers! I had a couple of questions/suggestions, see below.

group_vars/ezproxy/common.yml Show resolved Hide resolved
@@ -52,6 +34,13 @@
when:
- running_on_server

- name: Ezproxy | install ezproxy startup script (requires root)
ansible.builtin.command: /var/local/ezproxy/ezproxy -si
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this command create a file or install a service or something like? something we could use as a condition to make the command only run when it needs to? Then we wouldn't need the changed_when: false . . . or at the least we could set changed_when: to something more specific

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we get very little to go for what is does from the documentation 🤷

roles/ezproxy/tasks/main.yml Outdated Show resolved Hide resolved
roles/ezproxy/tasks/main.yml Outdated Show resolved Hide resolved
Copy link
Contributor Author

@VickieKarasic VickieKarasic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @kayiwa

@tpendragon tpendragon merged commit d877f27 into main Jan 13, 2025
73 checks passed
@tpendragon tpendragon deleted the i4788_ezproxy_test branch January 13, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants