Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orangelight] Add sidekiq #5712

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[orangelight] Add sidekiq #5712

merged 2 commits into from
Jan 9, 2025

Conversation

maxkadel
Copy link
Contributor

@maxkadel maxkadel commented Jan 8, 2025

Connected to pulibrary/orangelight#4609

This adds the sidekiq role to the orangelight playbook. A few things to note:

  • Some role dependencies are moved from the orangelight role to the orangelight playbook. This is because, when they were in the role, time-consuming tasks like the ruby_s tasks would run twice: first for the sidekiq boxes, then again for non-sidekiq boxes. Now that they are in the playbook, placed before the sidekiq role, ruby_s (and other tasks like bind9) only run once.
  • The sidekiq_worker_name does not contain the name of the application, as it does for bibdata. This is so we can simply run systemctl restart sidekiq, rather than having to figure out the application-specific sidekiq name.

sandbergja and others added 2 commits January 8, 2025 13:08
- This reduces duplication of running roles when running the playbook, and fixes a bug with the deploy_user role when we run the sidekiq role on a subset of boxes

Co-authored-by: Jane Sandberg <[email protected]>
@@ -22,6 +22,7 @@
run_once: true
tags: update_keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool!

Copy link
Member

@kayiwa kayiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Thanks @maxkadel

@kayiwa kayiwa merged commit a43d16b into main Jan 9, 2025
74 checks passed
@kayiwa kayiwa deleted the orangelight-sidekiq branch January 9, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants