Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed library-staging1 &2 from inventory #5702

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

dphillips-39
Copy link
Contributor

Co-authored-by: Vickie Karasic [email protected]

@dphillips-39 dphillips-39 force-pushed the i5406_decommission_library-staging1-2 branch 2 times, most recently from 9a55cf9 to bbee6f0 Compare January 14, 2025 15:27
@dphillips-39 dphillips-39 marked this pull request as ready for review January 14, 2025 15:34
@acozine
Copy link
Contributor

acozine commented Jan 14, 2025

Can you also remove the group from our other inventory files? See

and and

Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @dphillips-39 and @VickieKarasic ! When I run a playbook from this branch, I get:

* Failed to parse /Users/sandbergj/repos/princeton_ansible/inventory/by_environment/staging with ini plugin:
/Users/sandbergj/repos/princeton_ansible/inventory/by_environment/staging:27: Section [staging:children] includes undefined group: libwww_staging

Could you please remove libwww_staging from inventory/by_environment too so that we don't get this warning?

Edit: I just saw @acozine already said that! Apologies for the duplicate!

@VickieKarasic
Copy link
Contributor

@sandbergja and @acozine thanks for pointing this out! Just removed those files from our other groups and pushed my changes. I was going to hold off on removing libwww_production until we decommission those VMs at the end of this month, but let me know if removing sooner would be better (related to #5651)

@dphillips-39 dphillips-39 force-pushed the i5406_decommission_library-staging1-2 branch from 4e4e7e7 to 77a3609 Compare January 15, 2025 16:28
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, so nice to get this old group out of princeton_ansible. Thanks @VickieKarasic and @dphillips-39 !

@sandbergja sandbergja merged commit 63977d5 into main Jan 15, 2025
73 checks passed
@sandbergja sandbergja deleted the i5406_decommission_library-staging1-2 branch January 15, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants