[Cicognara] Removes inventory files #5655
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Vickie Karasic <[email protected]> Co-authored-by: Angel Ruiz <[email protected]>
dphillips-39
changed the title
kayiwa
reviewed
Jan 7, 2025
| @@ -12,12 +12,6 @@ named_sites: | |||
| repo_root: "/var/local/daviesproject" | |||
| git_repo: 'https://github.com/pulibrary/davies_project.git' | |||
| version: 'main' | |||
| - server_name: "cicognara.org" | |||
There was a problem hiding this comment.
indeed, the entries in libstatic need to stay
kayiwa
reviewed
Jan 7, 2025
| @@ -2,12 +2,6 @@ | |||
| # defaults file for roles/libstatic | |||
| running_on_server: true | |||
| named_sites: | |||
| - server_name: 'cicognara-staging.lib' | |||
There was a problem hiding this comment.
we want cicognara staging to continue to run.
kayiwa
reviewed
Jan 7, 2025
| @@ -10,12 +10,6 @@ named_sites: | |||
| repo_root: "/var/local/milberg" | |||
| git_repo: 'https://github.com/pulibrary/milberg-wp.git' | |||
| version: 'main' | |||
| - server_name: 'cicognara-staging.lib' | |||
There was a problem hiding this comment.
anything in libstatic should stay
kayiwa
reviewed
Jan 7, 2025
| @@ -132,7 +132,3 @@ | |||
| # lae redirects | |||
| # | |||
| rewrite ^/collections/pudl0025(.*)$ https://lae.princeton.edu$1 redirect; | |||
|
|
|||
kayiwa
requested changes
Jan 7, 2025
acozine
requested changes
Jan 7, 2025
| @@ -1,15 +1,11 @@ | |||
| --- | |||
| # by default this playbook runs in the staging environment | |||
| # to run in production, pass '-e runtime_env=production' | |||
| - name: build the cicognara site | |||
There was a problem hiding this comment.
This playbook can be deleted entirely. We do not want to build a standalone cicognara site any more.
| @@ -10,12 +10,6 @@ named_sites: | |||
| repo_root: "/var/local/milberg" | |||
| git_repo: 'https://github.com/pulibrary/milberg-wp.git' | |||
| version: 'main' | |||
| - server_name: 'cicognara-staging.lib' | |||
There was a problem hiding this comment.
anything in libstatic should stay
| @@ -11,15 +11,6 @@ upstream static-staging { | |||
| zone=static-stagingclient_sessions:1m; | |||
| } | |||
|
|
|||
| server { | |||
|
PR #5714 closes this PR |
|
retake #5714 replaces this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5586
Co-authored-by: Vickie Karasic [email protected]
Co-authored-by: Angel Ruiz [email protected]