Do not index SCSB items if they are private #2393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If there are only private items, skip indexing the whole record - If there is a mix of private and non-private items, only index the private items Connected to #2383
sandbergja
reviewed
Jun 5, 2024
| next if recap_notes.map { |note| note.include?("P") }.include?(false) | ||
|
|
||
| id = id_extractor.extract(record).first | ||
| context.skip!("Skipped #{id} because record includes only private items.") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connected to #2383
Tested successfully on staging using a file from SCSB that included private items.