Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move towards using config for DumpType #2352

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Move towards using config for DumpType #2352

merged 1 commit into from
Apr 23, 2024

Conversation

maxkadel
Copy link
Contributor

  • Replace instances of DumpType with dump_type_id - these ids are consistent across environments.

Connected to #2348

@maxkadel
Move towards using config for DumpType
e68c318 
- Replace instances of DumpType with dump_type_id - these ids are consistent across environments.
christinach
christinach reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxkadel

christinach
christinach approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@christinach christinach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxkadel

@christinach christinach merged commit 039ff66 into main Apr 23, 2024
10 checks passed
@christinach christinach deleted the i2348_use_dump_type_config branch April 23, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinach christinach christinach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxkadel @christinach