Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update delete events rake task #2297

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

christinach
Copy link
Member

closes #2289

Update delete events rake task to also delete recap partner full and recap partner daily updates

also update existing delete for all records to be every 2 weeks.

@christinach christinach force-pushed the 2289-update-delete-events-task branch from a54a636 to 543e524 Compare January 12, 2024 16:23
@christinach christinach marked this pull request as draft January 12, 2024 16:29
@christinach christinach force-pushed the 2289-update-delete-events-task branch from 543e524 to 641d07f Compare January 12, 2024 16:41
…recap partner daily updates

also update existing delete for all records to be every 2 weeks.
@christinach christinach force-pushed the 2289-update-delete-events-task branch from 641d07f to a99b563 Compare January 12, 2024 16:43
@christinach christinach marked this pull request as ready for review January 12, 2024 16:43
Copy link
Member

@sandbergja sandbergja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @christinach 🐬

@@ -56,6 +56,54 @@
expect(Dir.empty?(File.join(copy_path, full_event.id.to_s))).to be false
end
end
context "for partner ReCAP dump events with start date older than 2 months" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests are so nice an comprehensive!

@sandbergja sandbergja merged commit 616073c into main Jan 12, 2024
10 checks passed
@sandbergja sandbergja deleted the 2289-update-delete-events-task branch January 12, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update delete events task to purge daily SCSB Partner Files and SCSB Partner Full files Older than two months.
2 participants