Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eventlog parsing enhancements #182

Merged
merged 34 commits into from
Oct 27, 2024
Merged

Eventlog parsing enhancements #182

merged 34 commits into from
Oct 27, 2024

Conversation

puffyCid
Copy link
Owner

This large PR adds support for including template strings when parsing eventlogs.
This allows artemis to include the entire eventlog message when parsing evtx files (on Windows systems)

@puffyCid puffyCid changed the title Eventlogs enhancements Eventlog parsing enhancements Oct 27, 2024
Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 88.35961% with 347 lines in your changes missing coverage. Please review.

Project coverage is 84.96%. Comparing base (30af4bc) to head (e704956).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
core/src/artifacts/os/windows/eventlogs/parser.rs 68.31% 77 Missing ⚠️
core/src/artifacts/os/windows/eventlogs/combine.rs 93.53% 64 Missing ⚠️
...re/src/artifacts/os/windows/eventlogs/formaters.rs 82.29% 51 Missing ⚠️
...cts/os/windows/eventlogs/resources/manifest/xml.rs 87.35% 43 Missing ⚠️
core/src/artifacts/os/windows/pe/resources.rs 69.81% 32 Missing ⚠️
core/src/artifacts/os/windows/eventlogs/strings.rs 89.55% 26 Missing ⚠️
...s/os/windows/eventlogs/resources/manifest/table.rs 81.66% 11 Missing ⚠️
.../windows/eventlogs/resources/manifest/defintion.rs 89.15% 9 Missing ⚠️
core/src/artifacts/os/windows/eventlogs/error.rs 14.28% 6 Missing ⚠️
...rc/artifacts/os/windows/eventlogs/resources/mui.rs 92.10% 6 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   84.79%   84.96%   +0.16%     
==========================================
  Files         510      525      +15     
  Lines       62420    65363    +2943     
==========================================
+ Hits        52930    55534    +2604     
- Misses       9490     9829     +339     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@puffyCid puffyCid merged commit 3dafd31 into main Oct 27, 2024
9 checks passed
@puffyCid puffyCid deleted the eventlogs-update branch October 27, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant