Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMGUI_BUNDLE_DISABLE_IMGUI_NODE_EDITOR not working anymore #279

Open
wkjarosz opened this issue Nov 12, 2024 · 1 comment
Open

IMGUI_BUNDLE_DISABLE_IMGUI_NODE_EDITOR not working anymore #279

wkjarosz opened this issue Nov 12, 2024 · 1 comment

Comments

@wkjarosz
Copy link

I just tried to update my imgui_bundle dependency in HDRView to v1.5.2 and ran into build issues.

I've only had a bit of time to investigate so far, but best I can make out, the issue is that:

In my project I turn on IMGUI_BUNDLE_DISABLE_IMGUI_NODE_EDITOR, but it seems that ever since this commit, external/immapp/immapp/immapp_widgets.cpp depends on the node editor headers regardless of this CMAKE option.

I was able to get everything to build properly if I simply don't turn on IMGUI_BUNDLE_DISABLE_IMGUI_NODE_EDITOR, but since I don't depend on the node editor functionality, it would be nice to still allow disabling it.

@pthom
Copy link
Owner

pthom commented Nov 21, 2024

Hello,

Sorry to answer with a bit of delay. This will be solved in the upcoming v1.6.0 (due in a few days). It is already solved on the main branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants