Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple choice #4820

Merged
merged 2 commits into from
Dec 24, 2024
Merged

Fix multiple choice #4820

merged 2 commits into from
Dec 24, 2024

Conversation

3d-gussner
Copy link
Collaborator

@3d-gussner 3d-gussner commented Dec 16, 2024

Fixes #4819

Issue was that the second column was set to fixed position 8 which causes issues in most languages.
This cause the reported LCD overwriting by @Smooph86.

01234567890123456789
>Yes    >No   >Eject
>Ano    >Ne >Vysunout
>Ja     >Nein >Auswerf.
>Si     >No >Expulsar
>Oui    >Non >Éjecter
>Da     >Ne >Izbaciti
>Igen   >Nem >Kiadás
>Si     >No >Espelli
>Ja     >Nee >Uitwerp.
>Ja     >Nei >Løs ut
>Tak    >Nie  >Wysuń
>Da     >Nu >Scoateți
>Áno    >Nie >Vysunúť
>Ja     >Nej >Mata ut

Multi_choice_de
Multi_choice_cs
Multi_choice_nl

All translations of MSG_YES, MSG_NO and MSG_EJECT combined including the selector and spaces do not exceed the LCD width

01234567890123456789
>Yes >No      >Eject
>Ano >Ne   >Vysunout
>Ja >Nein  >Auswerf.
>Si >No    >Expulsar
>Oui >Non   >Éjecter
>Da >Ne    >Izbaciti
>Igen >Nem   >Kiadás
>Si >No     >Espelli
>Ja >Nee   >Uitwerp.
>Ja >Nei     >Løs ut
>Tak >Nie     >Wysuń
>Da >Nu    >Scoateți
>Áno >Nie   >Vysunúť
>Ja >Nej    >Mata ut

Fixed_Multi_choice_de

Second commit un-shortens German and Dutch translation and makes it more readable.

Long_fixed_multi_choice_de

Copy link

github-actions bot commented Dec 16, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 14 0 247770 5654 6182 2538
MK3_MULTILANG 14 0 247140 5663 6812 2529

Copy link
Collaborator

@sarusani sarusani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MK404.

@3d-gussner 3d-gussner merged commit 3ea620c into prusa3d:MK3 Dec 24, 2024
4 checks passed
@3d-gussner 3d-gussner deleted the MK3_Fix_multi_choice branch December 24, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 3.14.1 MK3S+ new filament load screen german translation broken
2 participants