Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiscreen message with Cont.|Cancel #4817

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

3d-gussner
Copy link
Collaborator

@3d-gussner 3d-gussner commented Nov 28, 2024

While working on new features which need some translated text I have reached the limit in French.
Here an approach to solve this issue.

Remove Continue? from some messages to save "translation space" and replace multiscreen from Yes|No to Cont.|Cancel
Remove Print canceled. from check messages to save again "translation space" and after confirming the message the Status Line shows that it has been stopped.

Saves a lot of "translation space" which was getting low especially for French translations.

From 45 free bytes in French to 236

Copy link

github-actions bot commented Nov 28, 2024

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG -102 0 247668 5654 6284 2538
MK3_MULTILANG -102 0 247038 5663 6914 2529

@3d-gussner 3d-gussner changed the title Add multiscreen message with Cont.|Cancel 🚧 WIP: Add multiscreen message with Cont.|Cancel Nov 28, 2024
@3d-gussner 3d-gussner requested review from gudnimg and leptun November 28, 2024 12:43
@3d-gussner 3d-gussner changed the title 🚧 WIP: Add multiscreen message with Cont.|Cancel Add multiscreen message with Cont.|Cancel Dec 2, 2024
@3d-gussner 3d-gussner marked this pull request as ready for review December 2, 2024 18:49
Copy link
Collaborator

@sarusani sarusani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on MK404.

Remove `Continue?` from some mesages to save "translation space" and replace multiscreen from `Yes|No` to `Cont.|Cancel`
Remove `Print canceled.` from check messages to save again "translation sapce" and after confirming the message the Status Line shows that it has been stopped.

fix rebase issue
@3d-gussner
Copy link
Collaborator Author

@sarusani please review again after fixing rebase issues.

@3d-gussner 3d-gussner requested a review from sarusani December 24, 2024 07:02
@3d-gussner 3d-gussner merged commit e10c8d9 into prusa3d:MK3 Dec 30, 2024
4 checks passed
@3d-gussner 3d-gussner deleted the MK3_Short_messages branch December 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants