Fix an issue in first layer calibration where MMU unloads with disabled hotend heater #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gudnimg
changed the title
…ed hotend heater Change in memory: Flash: -16 bytes SRAM: 0 bytes
gudnimg
force-pushed
the
fix-lay1cal-mmu-unload
branch
from
9ed0d82 to
365988e
Compare
|
All values in bytes. Δ Delta to base
|
leptun
approved these changes
Nov 17, 2024
There was a problem hiding this comment.
This does feel a bit hacky, but it also simplifies lay1cal_finish quite a bit. So I think we should go forward with this, but not directly. I would move these changes on top of #4811 and close this PR.
Also really nice touch by disabling the bed while unloading the filament👍
|
superseded by #4811 and merged into that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor issue I found while reviewing #4811
Change in memory:
Flash: -16 bytes
SRAM: 0 bytes