Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMU: Set PAUSED_FOR_USER state on MMU error screen #4471

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

gudnimg
Copy link
Collaborator

@gudnimg gudnimg commented Oct 28, 2023

Setting this state notifies PrusaLink/PrusaConnect that the printer is waiting for user input (attention).

Resolves #4470

Change in memory:
Flash: +12 bytes
SRAM: 0 bytes

Setting this state notifies PrusaLink/PrusaConnect
that the printer is waiting for user input (attention).

Change in memory:
Flash: +12 bytes
SRAM: 0 bytes
@github-actions
Copy link

All values in bytes. Δ Delta to base

Target ΔFlash ΔSRAM Used Flash Used SRAM Free Flash Free SRAM
MK3S_MULTILANG 12 0 245922 5633 8030 2559
MK3_MULTILANG 12 0 245206 5642 8746 2550

@gudnimg gudnimg added the Prusa-Link_Connect Prusa Link and Prusa Connect related label Oct 28, 2023
@firetech
Copy link

I built a test firmware with this cherry-picked on top of 3.13.2 (7aff0db), and did some quick tests with induced failures, both from idle state (Load to nozzle) and from within a print. Seems to work. :)
image

@gudnimg gudnimg requested review from 3d-gussner and DRracer October 29, 2023 10:18
@gudnimg
Copy link
Collaborator Author

gudnimg commented Oct 29, 2023

I did a few tests on my side:

  • ✅ M600 with MMU (Tested the new filament change screen in 3.13.2)
  • SELECTOR CANNOT HOME when Idle. When the firmware is running the top-level loop() the status is reset, I rather not touch this code.

@gudnimg gudnimg changed the title 🚧 MMU: Set PAUSED_FOR_USER state on MMU error screen MMU: Set PAUSED_FOR_USER state on MMU error screen Oct 29, 2023
@3d-gussner 3d-gussner added this to the FW 3.14.0 milestone Oct 30, 2023
Copy link
Collaborator

@3d-gussner 3d-gussner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with MK404, PrusaLink 0.72.0 and PrusaConnect

Test Steps:

  1. Start MK404 with MMU
  2. Start prusalink -s /tmp/simavr-uart0 -l prusa.link.serial.serial_adapter=DEBUG -i -f
  3. In PrusaConnect start SD print
  4. During print press "F" in MK404 to manually set FINDA
  5. Wait for MMU error
  6. Check in PrusaLink and PrusaConnect the printer state

Before:
PrusaLink and PrusaConnect don't detect any issue and printer state says printing

With this PR:
PruasLink and PrusaConncet change state to Attention

@3d-gussner 3d-gussner merged commit fca93b0 into prusa3d:MK3 Oct 31, 2023
5 checks passed
@gudnimg gudnimg deleted the issue-4470 branch October 31, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prusa-Link_Connect Prusa Link and Prusa Connect related
Projects
None yet
3 participants