3.13.2 Cherry-pick PFW-1542 Don't allow starting SD print if there is a thermal or fan error #4450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply same conditions as on "Resume print" feature. Starting a SD print should not be possible if there is an active hardware error
If the error is really resolved, I'd prefer to see "Prusa i3 MK3S OK" instead of "Err:HOTEND FAN ERROR"
|
3d-gussner
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Tested on MK404
- Stall fan
- Start SD print
- 65~ish
Err:HOTEND FAN ERRORdetected ✔️ - Resume fan --> Resume menu ✔️
- Stall fan -->
Err:HOTEND FAN ERROR✔️ - Again and again these steps ✔️
2nd test
- Stall fan
- Start SD print
- 65~ish
Err:HOTEND FAN ERRORdetected ✔️ - Stop print
Err:HOTEND FAN ERROR- Limited menu without Print SD ✔️
- But it times out and is shown even
- Fan is still stalled
- Fan check isn't disabled
- Good is that the next Print from SD errors out correctly with stalled fan ✔️
- Settings -> Fancheck [Off] works well
- But it times out and is shown even
- With Fan check [Off] and stalled fan the print starts ✔️
- As soon I turn on in Tune -> Fan check [On] it errors out correctly ✔️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #4449 for 3.13.2
Two small fixes:
"Prusa i3 MK3S OK"instead of"Err:HOTEND FAN ERROR"